fix: allow null on bucket constraints

supabase · Apr 11, 2023 · a6beed6 · a6beed6
1 parent 88928fd
commit a6beed6
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/src/packages/StorageBucketApi.ts b/src/packages/StorageBucketApi.ts
@@ -74,13 +74,17 @@ export default class StorageBucketApi {
    *
    * @param id A unique identifier for the bucket you are creating.
    * @param options.public The visibility of the bucket. Public buckets don't require an authorization token to download objects, but still require a valid token for all other operations. By default, buckets are private.
-   * @param options.fileSizeLimit specifies the file size limit that this bucket can accept during upload
-   * @param options.allowedMimeTypes specifies the allowed mime types that this bucket can accept during upload
+   * @param options.fileSizeLimit specifies the file size limit that this bucket can accept during upload, pass null to remove the constraint
+   * @param options.allowedMimeTypes specifies the allowed mime types that this bucket can accept during upload, pass null to remove the constraint
    * @returns newly created bucket id
    */
   async createBucket(
     id: string,
-    options: { public: boolean; fileSizeLimit?: number | string; allowedMimeTypes?: string[] } = {
+    options: {
+      public: boolean
+      fileSizeLimit?: number | string | null
+      allowedMimeTypes?: string[] | null
+    } = {
       public: false,
     }
   ): Promise<
@@ -121,12 +125,16 @@ export default class StorageBucketApi {
    *
    * @param id A unique identifier for the bucket you are updating.
    * @param options.public The visibility of the bucket. Public buckets don't require an authorization token to download objects, but still require a valid token for all other operations.
-   * @param options.fileSizeLimit specifies the file size limit that this bucket can accept during upload
-   * @param options.allowedMimeTypes specifies the allowed mime types that this bucket can accept during upload
+   * @param options.fileSizeLimit specifies the file size limit that this bucket can accept during upload, pass null to remove the constraint
+   * @param options.allowedMimeTypes specifies the allowed mime types that this bucket can accept during upload, pass null to remove the constraint
    */
   async updateBucket(
     id: string,
-    options: { public: boolean; fileSizeLimit?: number | string; allowedMimeTypes?: string[] }
+    options: {
+      public: boolean
+      fileSizeLimit?: number | string | null
+      allowedMimeTypes?: string[] | null
+    }
   ): Promise<
     | {
         data: { message: string }