-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ID and full path of uploaded file #168
Conversation
Hey @awalias @soedirgo @inian @kiwicopple this is a PR for your consideration, it would help us greatly to adopt the storage and make it easier to use via the JS client. |
Any maintainer willing to help? |
Hey @bombillazo i'll look at this ASAP |
Hey @fenos any update? |
Any update on this??? |
Any update? |
Hey mate have you had time to look into it? I'm currently in need of this feature |
Hi @bombillazo, this PR needs v3 of our storage to be rolled out to everyone since only v3 returns the id of the uploaded file. We still have a few regions to roll out for v3, but aiming to do that by the first week of October. We will merge the PR right after. As a workaround, you can contact support to upgrade your own projects to v3, if it hasn't already been upgraded, and use a fork version of storage-js till next month. Apologies for the lack of communication here! |
Thanks for the updates! |
🎉 This PR is included in version 2.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Bug fix for #170
What is the current behavior?
Currently, only part of the path (not including the bucket) of the uploaded file is returned even though the API returns both the ID and full path of the file: source
What is the new behavior?
The new behavior is for the response of the upload client call to return the id and full path in addition to the path.