Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ID and full path of uploaded file #168

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

bombillazo
Copy link
Contributor

@bombillazo bombillazo commented Jun 29, 2023

What kind of change does this PR introduce?

Bug fix for #170

What is the current behavior?

Currently, only part of the path (not including the bucket) of the uploaded file is returned even though the API returns both the ID and full path of the file: source

What is the new behavior?

The new behavior is for the response of the upload client call to return the id and full path in addition to the path.

@bombillazo
Copy link
Contributor Author

bombillazo commented Jun 29, 2023

Hey @awalias @soedirgo @inian @kiwicopple this is a PR for your consideration, it would help us greatly to adopt the storage and make it easier to use via the JS client.

@bombillazo
Copy link
Contributor Author

Any maintainer willing to help?

@fenos
Copy link
Contributor

fenos commented Jul 11, 2023

Hey @bombillazo i'll look at this ASAP

@bombillazo
Copy link
Contributor Author

Hey @fenos any update?

@bombillazo
Copy link
Contributor Author

Any update on this???

@bombillazo
Copy link
Contributor Author

Any update?

@WildEgo
Copy link

WildEgo commented Aug 30, 2023

Hey @bombillazo i'll look at this ASAP

Hey mate have you had time to look into it? I'm currently in need of this feature

@bombillazo
Copy link
Contributor Author

bombillazo commented Sep 8, 2023

Please, is there any update on this?

@soedirgo @inian @fenos

@inian
Copy link
Member

inian commented Sep 9, 2023

Hi @bombillazo, this PR needs v3 of our storage to be rolled out to everyone since only v3 returns the id of the uploaded file. We still have a few regions to roll out for v3, but aiming to do that by the first week of October. We will merge the PR right after. As a workaround, you can contact support to upgrade your own projects to v3, if it hasn't already been upgraded, and use a fork version of storage-js till next month.

Apologies for the lack of communication here!

@bombillazo
Copy link
Contributor Author

Thanks for the updates!

@fenos fenos merged commit fdfb120 into supabase:main Nov 14, 2023
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants