Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #5 support server side storage upload #17

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

thebengeu
Copy link
Member

No description provided.

@thebengeu thebengeu requested a review from inian July 16, 2021 09:04
@inian
Copy link
Member

inian commented Jul 17, 2021

Can you fix the tests Beng? Rest looks good

@thebengeu thebengeu force-pushed the 5_server_side_storage_upload branch from 1abdd22 to b03641a Compare July 19, 2021 05:32
@thebengeu
Copy link
Member Author

Made substantial changes to accommodate the update operation, please take a look.

@thebengeu thebengeu force-pushed the 5_server_side_storage_upload branch 2 times, most recently from 52ff6e2 to 3e86b94 Compare July 19, 2021 06:06
@thebengeu thebengeu force-pushed the 5_server_side_storage_upload branch from 3e86b94 to 6fdecb7 Compare July 19, 2021 06:26
| ArrayBufferView
| Blob
| File
| FormData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Users can pass in FormData in directly now

@inian inian merged commit 9f36c20 into main Jul 19, 2021
@inian inian deleted the 5_server_side_storage_upload branch July 19, 2021 06:38
@kiwicopple
Copy link
Member

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants