fix(gotrue): remove OtpType deprecation and add assertion to check ty…

…pe for resend method (#567) * remove otp type deprecation * Update packages/gotrue/lib/src/gotrue_client.dart Co-authored-by: Vinzent <vinzent03@proton.me> * Update packages/gotrue/lib/src/gotrue_client.dart --------- Co-authored-by: Vinzent <vinzent03@proton.me>
supabase · Jul 25, 2023 · d4509de · d4509de
1 parent 7fbd94c
commit d4509de
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/gotrue/lib/src/constants.dart b/packages/gotrue/lib/src/constants.dart
@@ -50,10 +50,8 @@ extension GenerateLinkTypeExtended on GenerateLinkType {
 enum OtpType {
   sms,
   phoneChange,
-  @Deprecated('Use OtpType.email instead')
   signup,
   invite,
-  @Deprecated('Use OtpType.email instead')
   magiclink,
   recovery,
   emailChange,

diff --git a/packages/gotrue/lib/src/gotrue_client.dart b/packages/gotrue/lib/src/gotrue_client.dart
@@ -526,9 +526,11 @@ class GoTrueClient {
     );
   }
 
-  ///Resends an existing signup confirmation email, email change email, SMS OTP or phone change OTP.
+  /// Resends an existing signup confirmation email, email change email, SMS OTP or phone change OTP.
   ///
-  ///Use [EmailResendParams] or [PhoneResendParams] to specify the type of resend.
+  /// For [type] of [OtpType.signup] or [OtpType.emailChange] [email] must be
+  /// provided, and for [type] or [OtpType.sms] or [OtpType.phoneChange],
+  /// [phone] must be provided
   Future<ResendResponse> resend({
     String? email,
     String? phone,
@@ -538,6 +540,14 @@ class GoTrueClient {
   }) async {
     assert((email != null && phone == null) || (email == null && phone != null),
         '`email` or `phone` needs to be specified.');
+    if (email != null) {
+      assert([OtpType.signup, OtpType.emailChange].contains(type),
+          'email must be provided for type ${type.name}');
+    }
+    if (phone != null) {
+      assert([OtpType.sms, OtpType.phoneChange].contains(type),
+          'phone must be provided for type ${type.name}');
+    }
 
     if (type != OtpType.emailChange && type != OtpType.phoneChange) {
       _removeSession();