Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotrue): remove import of dart:io from gotrue_client.dart #659

Merged
merged 1 commit into from Oct 7, 2023

Conversation

kaboc
Copy link
Contributor

@kaboc kaboc commented Oct 5, 2023

Fixes #658

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

What is the new behavior?

  • Removed the import dart:io from gotrue_client.dart to enable Dart web apps to be built successfully.

Additional context

dart:io was only used to refer to SocketException in the document of the _callRefreshToken() method. SocketException was replaced with ClientException in 6b5966f.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks great!

@dshukertjr dshukertjr merged commit 7280b49 into supabase:main Oct 7, 2023
10 checks passed
@dshukertjr
Copy link
Member

We will do one last release this upcoming Monday and defer the release of v2 to the following week.

@kaboc kaboc deleted the fix/remove-dart-io branch October 7, 2023 01:26
dshukertjr added a commit that referenced this pull request Oct 18, 2023
* feat: send messages via broadcast endpoint (#654)

* feat: send messages via broadcast endpoint

* chore: allow lower http version

* fix: fixes and add tests

* test: fix

* fix: compile with webdev (#653)

* chore(release): publish packages (#655)

- realtime_client@1.3.0
 - supabase@1.11.7
 - supabase_flutter@1.10.20

* chore(release): publish packages (#656)

- gotrue@1.12.3
 - storage_client@1.5.3
 - supabase@1.11.8
 - supabase_flutter@1.10.21

* fix(gotrue): remove import of dart:io from gotrue_client.dart (#659)

Remove import of dart:io from gotrue_client.dart

* chore(release): publish packages (#663)

- gotrue@1.12.4
 - supabase@1.11.9
 - supabase_flutter@1.10.22

* test: use ClientException

* test: remove unused import

---------

Co-authored-by: Tyler <18113850+dshukertjr@users.noreply.github.com>
Co-authored-by: Kabo <20254485+kaboc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build a Dart web app due to dependency on dart:io in gotrue 1.12.3
2 participants