Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare web support #392

Merged
merged 3 commits into from Mar 10, 2023
Merged

fix: declare web support #392

merged 3 commits into from Mar 10, 2023

Conversation

Vinzent03
Copy link
Collaborator

The previous fix didn't work, because universal_io is still listed as not supported. I'm now hard coding the supported platforms as described here. Hopefully it works this time.

I added a section about linux support in the readme, because one might think we don't support linux at all.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Sweet! I genuinely did not know that you can just declare what platform the package supports! Could we bump the package version and I can quickly release it!

@Vinzent03
Copy link
Collaborator Author

What about using #381 for this?

@dshukertjr
Copy link
Member

@Vinzent03 Sounds great!

@dshukertjr dshukertjr merged commit 8b9691a into main Mar 10, 2023
1 of 2 checks passed
@dshukertjr dshukertjr deleted the fix/pub branch March 10, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants