Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Passing null to not() filter is now allowed #775

Merged
merged 2 commits into from Dec 22, 2023
Merged

fix: Passing null to not() filter is now allowed #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b99b116
fix: Passing null to not filter not allowed bug
dshukertjr Dec 21, 2023
cd3b2f7
update test
dshukertjr Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/postgrest/lib/src/postgrest_filter_builder.dart
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ class PostgrestFilterBuilder<T> extends PostgrestTransformBuilder<T> {
/// .select()
/// .not('status', 'eq', 'OFFLINE');
/// ```
PostgrestFilterBuilder<T> not(String column, String operator, Object value) {
PostgrestFilterBuilder<T> not(String column, String operator, Object? value) {
final Uri url;
if (value is List) {
if (operator == "in") {
Expand Down
8 changes: 8 additions & 0 deletions packages/postgrest/test/filter_test.dart
View file
Open in desktop
Expand Up @@ -45,6 +45,14 @@ void main() {
}
});

test('not with is null', () async {
final res = await postgrest
.from('users')
.select('username')
.not('username', 'is', null);
expect(res.length, 4);
});

test('not with List of values', () async {
final res = await postgrest
.from('users')
Expand Down