feat(functions): add experimental invoke with streamed responses #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
force-pushed
the
feat/functions/invoke-stream-response
branch
from
4840b25
to
ce8cedc
Compare
|
So this PR introduces a new public method |
|
The |
|
Didn't know that! Thanks for educating me! |
grdsdev
force-pushed
the
feat/functions/invoke-stream-response
branch
from
ce8cedc
to
8c9d3ce
Compare
dshukertjr
approved these changes
Apr 22, 2024
jareddr
reviewed
May 7, 2024
| ) async throws -> Response { | ||
| var request = Request( | ||
| path: functionName, | ||
| method: .post, |
There was a problem hiding this comment.
This line is causing a major bug in the library. Upon upgrading our client version, we can no longer make GET/PUT/DELETE requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Close #252
Add experimental method to invoke function with streamed responses
Why is it sill experimental?
To implement the streamed responses, we need to set up a custom
URLSessionfor setting itsdelegateproperty, which means that it doesn't use thecustomFetchthat is provided to thefunctionspackage and all othersub-packages.I prefer keeping it
Experimentaluntil we try to refactor the code so that all requests uses the sameURLSessioninstance.