-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(functions): add experimental invoke with streamed responses #346
Conversation
4840b25
to
ce8cedc
Compare
So this PR introduces a new public method |
The |
Didn't know that! Thanks for educating me! |
ce8cedc
to
8c9d3ce
Compare
) async throws -> Response { | ||
var request = Request( | ||
path: functionName, | ||
method: .post, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing a major bug in the library. Upon upgrading our client version, we can no longer make GET/PUT/DELETE requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of change does this PR introduce?
Close #252
Add experimental method to invoke function with streamed responses
Why is it sill experimental?
To implement the streamed responses, we need to set up a custom
URLSession
for setting itsdelegate
property, which means that it doesn't use thecustomFetch
that is provided to thefunctions
package and all othersub-packages
.I prefer keeping it
Experimental
until we try to refactor the code so that all requests uses the sameURLSession
instance.