Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'["China", "France"]' or ['China', 'France'] in docs? #22

Closed
awalias opened this issue Feb 19, 2020 · 4 comments
Closed

'["China", "France"]' or ['China', 'France'] in docs? #22

awalias opened this issue Feb 19, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@awalias
Copy link
Member

awalias commented Feb 19, 2020

image

https://supabase.io/docs/library/get/#in

'["China", "France"]' or ['China', 'France'] ?
need to test whether this should be wrapped as a string or not

currently facing other issues which means I can't test it right now, so saving here for later investigation

@awalias awalias added the good first issue Good for newcomers label Feb 19, 2020
@kiwicopple
Copy link
Member

need to test whether this should be wrapped as a string or not

Should be a plain array:
https://github.com/supabase/postgrest-js/blob/3eca6e8459630bd959355fad1b48e5ee31b33bf7/src/utils/Filters.js#L158

Not sure why it's failing, tests seem to be OK:
https://github.com/supabase/postgrest-js/blob/master/README.md#status

@awalias
Copy link
Member Author

awalias commented Feb 20, 2020

this is the error

      text: '{"details":"unexpected \\"2\\" expecting \\"(\\"","message":"\\"failed to parse filter (in.2,3)\\" (line 1, column 4)"}',
      method: 'GET',
      path: '/rest/v1/users?apikey=examplekey&id=in.2,3&select=%2A'

@awalias
Copy link
Member Author

awalias commented Feb 20, 2020

ok so looks like it should be getting wrapped with parenthesis like:
http://localhost:8000/rest/v1/users?apikey=examplekey&id=in.(2,3)&select=*

@kiwicopple
Copy link
Member

Fixed in postgrest-js@0.8.0

@awalias awalias closed this as completed Feb 20, 2020
vonovak pushed a commit to vonovak/supabase that referenced this issue Mar 1, 2024
vonovak pushed a commit to vonovak/supabase that referenced this issue Mar 1, 2024
fix: supabase#22 wont throw error for confirmation email signups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants