Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change postgis function to returns table #16177

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix: change postgis function to returns table #16177

merged 4 commits into from
Aug 17, 2023

Conversation

steve-chavez
Copy link
Member

Mitigates the error reported on supabase/postgrest-js#453

@steve-chavez steve-chavez requested a review from a team as a code owner August 2, 2023 21:15
@vercel
Copy link

vercel bot commented Aug 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:29am
studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:29am
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:29am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:29am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:29am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
supabase-studio-prod ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 5:29am
supabase-studio-staging ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 5:29am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 5:29am

dshukertjr
dshukertjr reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another sample postgres function that needs similar fixing. Let me fix it and push it to this branch right now.

apps/docs/pages/guides/database/extensions/postgis.mdx Outdated Show resolved Hide resolved
@dshukertjr dshukertjr requested a review from a team as a code owner August 3, 2023 07:33
dshukertjr
dshukertjr reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an blog article that uses the same code, so included the update of the article in this PR as well.

apps/www/_blog/2023-03-01-geo-queries-with-postgis-in-ionic-angular.mdx Show resolved Hide resolved
apps/www/_blog/2023-03-01-geo-queries-with-postgis-in-ionic-angular.mdx Show resolved Hide resolved
@dshukertjr dshukertjr mentioned this pull request Aug 3, 2023
Open
@steve-chavez
Copy link
Member Author

@dshukertjr Sorry for the late reply! Great feedback!

This looks ready to merge now.

@dshukertjr dshukertjr merged commit 5b02541 into master Aug 17, 2023
11 checks passed
@dshukertjr dshukertjr deleted the fix-postgis branch August 17, 2023 06:25
@steve-chavez steve-chavez mentioned this pull request Aug 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

@gregnr gregnr Awaiting requested review from gregnr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steve-chavez @dshukertjr