Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/UI feature previews #17775

Merged
merged 5 commits into from Sep 29, 2023
Merged

Feat/UI feature previews #17775

merged 5 commits into from Sep 29, 2023

Conversation

joshenlim
Copy link
Member

No description provided.

@joshenlim joshenlim requested a review from a team as a code owner September 28, 2023 08:54
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 9:36am
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 9:36am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 9:36am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 9:36am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 9:36am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 9:36am

}

const FeaturePreviewContext = createContext<FeaturePreviewContextType>({
flags: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use EMPTY_OBJ here?

import { Markdown } from '../Markdown'
import { useFeaturePreviewContext } from './FeaturePreviewContext'

const FEATURE_PREVIEWS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this to a separate file, together with LOCAL_STORAGE_KEYS. We should make adding new feature previews as simple as possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha on this - i'll add this as a comment in the file itself for now

@joshenlim joshenlim merged commit 32dda1b into master Sep 29, 2023
13 checks passed
@joshenlim joshenlim deleted the feat/ui-feature-previews branch September 29, 2023 05:20
encima pushed a commit to faizanraso/supabase that referenced this pull request Jan 8, 2024
* Break me.tsx into smaller components

* Deprecate duplicate app valtio state

* Initialize feature preview modal

* Add telemetry

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants