New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/UI feature previews #17775
Feat/UI feature previews #17775
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
} | ||
|
||
const FeaturePreviewContext = createContext<FeaturePreviewContextType>({ | ||
flags: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use EMPTY_OBJ
here?
import { Markdown } from '../Markdown' | ||
import { useFeaturePreviewContext } from './FeaturePreviewContext' | ||
|
||
const FEATURE_PREVIEWS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move this to a separate file, together with LOCAL_STORAGE_KEYS
. We should make adding new feature previews as simple as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha on this - i'll add this as a comment in the file itself for now
* Break me.tsx into smaller components * Deprecate duplicate app valtio state * Initialize feature preview modal * Add telemetry * Address comments
No description provided.