Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LinkedIn OIDCProvider #18225

Merged
merged 7 commits into from Oct 18, 2023
Merged

feat: add LinkedIn OIDCProvider #18225

merged 7 commits into from Oct 18, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Oct 16, 2023

What kind of change does this PR introduce?

We introduce a LinkedIn (OIDC) provider and plan to deprecate the existing LinkedIn provider. To that end, we have greyed out the LinkedIn provider(except for toggle) in hopes of encouraging developers to move over from LinkedIn (Deprecated) to LinkedIn (OIDC)

Supports: https://github.com/supabase/infrastructure/pull/15177

  • Need to update the corresponding docs

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:10am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:10am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 11:10am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 11:10am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 11:10am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 11:10am

@notion-workspace
Copy link

2 similar comments
@notion-workspace
Copy link

@notion-workspace
Copy link

Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add that developers would need to include the following scopes on the linkedin dev platform:
image

Other than that, it LGTM from the docs side of things

@J0
Copy link
Contributor Author

J0 commented Oct 18, 2023

Oh I think it's actually included when one requests access for Sign In with LinkedIn OIDC - I think it's a good idea to remind devs to check though. Have added it in.

@J0 J0 merged commit 911d0a4 into master Oct 18, 2023
13 checks passed
@J0 J0 deleted the j0/add_linkedin branch October 18, 2023 13:02
encima pushed a commit to faizanraso/supabase that referenced this pull request Jan 8, 2024
* feat: initial commit for linkedin

* fix: update docs

* chore: add italics on linkedin

* feat: add scopes image

* Apply suggestions from code review

* chore: run prettier

---------

Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants