New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LinkedIn OIDCProvider #18225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
2 similar comments
kangmingtay
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I think it's actually included when one requests access for Sign In with LinkedIn OIDC - I think it's a good idea to remind devs to check though. Have added it in. |
J0
commented
Oct 18, 2023
studio/components/interfaces/Auth/AuthProvidersForm/ProviderForm.tsx
Outdated
Show resolved
Hide resolved
J0
commented
Oct 18, 2023
studio/components/interfaces/Auth/AuthProvidersForm/ProviderForm.tsx
Outdated
Show resolved
Hide resolved
ivasilov
approved these changes
Oct 18, 2023
alaister
approved these changes
Oct 18, 2023
encima
pushed a commit
to faizanraso/supabase
that referenced
this pull request
Jan 8, 2024
* feat: initial commit for linkedin * fix: update docs * chore: add italics on linkedin * feat: add scopes image * Apply suggestions from code review * chore: run prettier --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We introduce a LinkedIn (OIDC) provider and plan to deprecate the existing LinkedIn provider. To that end, we have greyed out the LinkedIn provider(except for toggle) in hopes of encouraging developers to move over from LinkedIn (Deprecated) to LinkedIn (OIDC)
Supports: https://github.com/supabase/infrastructure/pull/15177