Chore/improved error surfacing in sql editor #18327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joshenlim
commented
Oct 19, 2023
•
joshenlim
commented
- SQL editor will now show which line the error is at
- Error line will be scrolled to and highlighted
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
alaister
requested changes
Oct 19, 2023
studio/components/interfaces/SQLEditor/UtilityPanel/UtilityTabResults.tsx
Outdated
Show resolved
Hide resolved
…Results.tsx Co-authored-by: Alaister Young <alaister@users.noreply.github.com>
alaister
reviewed
Oct 19, 2023
Co-authored-by: Alaister Young <alaister@users.noreply.github.com>
encima
pushed a commit
to faizanraso/supabase
that referenced
this pull request
Jan 8, 2024
* Improved error surfacing for SQL editor * Remove unnecessary style * Improve logic * Update studio/components/interfaces/SQLEditor/UtilityPanel/UtilityTabResults.tsx Co-authored-by: Alaister Young <alaister@users.noreply.github.com> * Add guard * Update studio/components/interfaces/SQLEditor/SQLEditor.tsx Co-authored-by: Alaister Young <alaister@users.noreply.github.com> --------- Co-authored-by: Alaister Young <alaister@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.