Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mime type wildcard hint for storage bucket #19062

Merged
merged 2 commits into from Nov 20, 2023

Conversation

navaneeth-dev
Copy link
Contributor

@navaneeth-dev navaneeth-dev commented Nov 18, 2023

What kind of change does this PR introduce?

fixes #19057

Additional Context

There was another PR open but he did not edit all the files so I just created a new PR since I didn't know how to contribute to an existing PR.

@navaneeth-dev navaneeth-dev requested a review from a team as a code owner November 18, 2023 06:40
Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:07am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:07am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:07am
studio ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:07am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:07am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:07am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:07am

Copy link

vercel bot commented Nov 18, 2023

@navaneeth-dev is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@Akash187
Copy link
Contributor

Good job. Looks good.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @navaneeth-dev!

Note that I updated the the description to include that wildcards are allowed, since I think it makes more sense than having both image/jpeg and image/* in the placeholder text as image/* would already include image/jpeg

@alaister alaister merged commit cba1b07 into supabase:master Nov 20, 2023
15 checks passed
encima pushed a commit to faizanraso/supabase that referenced this pull request Jan 8, 2024
* chore: wildcard hint for mime type

* update copy

---------

Co-authored-by: Alaister Young <a@alaisteryoung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mime type wildcard hint in Create storage bucket UI
3 participants