Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/notifications v2 #19162

Merged
merged 24 commits into from
Jan 8, 2024
Merged

feat/notifications v2 #19162

merged 24 commits into from
Jan 8, 2024

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented Nov 23, 2023

Example:

image

@joshenlim joshenlim requested a review from a team as a code owner November 23, 2023 06:12
@joshenlim joshenlim marked this pull request as draft November 23, 2023 06:12
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:28am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am
studio ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am
studio-staging ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:28am

Copy link

supabase bot commented Nov 23, 2023

Updates to Preview Branch (feat/notifications-v2) ↗︎

Deployments Status Updated
Database Fri, 05 Jan 2024 05:11:49 GMT
Services Fri, 05 Jan 2024 05:11:49 GMT
APIs Fri, 05 Jan 2024 05:11:49 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Fri, 05 Jan 2024 05:11:49 GMT
Seeding Fri, 05 Jan 2024 05:11:49 GMT

⚠️ Warning — Preview branch version (15.1.0.133) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database postgres://postgres:[PASSWORD]@db.hkjemikdkpiukhhpbfuh.supabase.co:5432/postgres
REST API https://hkjemikdkpiukhhpbfuh.supabase.co/rest/v1 ↗︎
GraphQL https://hkjemikdkpiukhhpbfuh.supabase.co/graphql/v1 ↗︎

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Couple of small nits:

@joshenlim joshenlim merged commit 34a2ccd into master Jan 8, 2024
16 checks passed
@joshenlim joshenlim deleted the feat/notifications-v2 branch January 8, 2024 04:52
encima pushed a commit to faizanraso/supabase that referenced this pull request Jan 8, 2024
* Midway implementation notifications v2

* Some updates to Tab component

* Midway implementation notifications v2 again

* implement infinite scrolling and loading for notification sv2

* Add button actions

* Implement archive notifications

* Add filter dropdown for notifications

* Update date format

* Small style fix

* Update

* Update API codegen

* Add empt state

* Add empty state for archived notifications

* Fix type

* Final changes to notifications v2

* Small style fix

* Small fix

* Only mark notifications that come into view as read

* Update package lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants