Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/homepage connect modal combined #20328

Merged
merged 74 commits into from Feb 15, 2024
Merged

Conversation

saltcod
Copy link
Contributor

@saltcod saltcod commented Jan 11, 2024

new connect ui

connect-ui

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 0:21am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am
docs ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am
studio ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 0:21am

Copy link

supabase bot commented Jan 11, 2024

Updates to Preview Branch (feat/homepage-connect-modal-combined) ↗︎

Deployments Status Updated
Database Thu, 15 Feb 2024 12:18:00 GMT
Services Thu, 15 Feb 2024 12:18:00 GMT
APIs Thu, 15 Feb 2024 12:18:00 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Thu, 15 Feb 2024 12:18:00 GMT
Seeding Thu, 15 Feb 2024 12:18:00 GMT

⚠️ Warning — Preview branch version (15.1.0.155) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database https://supabase.com/dashboard/project/rvkpebzkxgwcoavwpczx/settings/database ↗︎
REST https://rvkpebzkxgwcoavwpczx.supabase.co/rest/v1
GraphQL https://rvkpebzkxgwcoavwpczx.supabase.co/graphql/v1

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

@joshenlim
Copy link
Member

joshenlim commented Feb 9, 2024

just checking the latest changes:

  • nested tabs look a little weird here, am thinking how to make this better (@MildTomato wondering if you might have an idea at the top of your head here)

  • source dropdown and documentation buttons are not aligned
    image

  • I haven't seen the code that deeply yet but are there some API calls which is causing the latency here? The code snippet goes empty for a brief moment - if there is lets add <GenericSkeletonLoader />

Screen.Recording.2024-02-09.at.16.56.44.mov

@MildTomato
Copy link
Contributor

MildTomato commented Feb 12, 2024

nested tabs look a little weird here, am thinking how to make this better (@MildTomato wondering if you might have an idea at the top of your head here)

Think it's fine to ship. We certainly have better ways of doing this but it'll stop velocity if we try and improve it today.
I reckon we can upgrade the connection string interface on another pass later?

Might also help if there's more direction with settings config designs first anyway.

Just don't want to hold up this PR 🚀

@saltcod
Copy link
Contributor Author

saltcod commented Feb 12, 2024

Thanks Joshen!

— the nested tabs definitely aren't ideal. We should redo rethink that entire component (probably after the ipv6 migration is totally settled)

— Wasn't seeing the RR dropdown locally — fixed that:
screenshot-2024-02-12-at-15 47 45

— loading issue
The files are being imported dynamically so there is a tiny-tiny lag while that happens.I suspect it'll be imperceptible on production, but added a skeleton loader.

@saltcod saltcod merged commit cc008ef into master Feb 15, 2024
16 checks passed
@saltcod saltcod deleted the feat/homepage-connect-modal-combined branch February 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants