Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email template preview #20681

Merged
merged 3 commits into from Jan 24, 2024
Merged

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Jan 23, 2024

What kind of change does this PR introduce?

  • Adds the option to preview your email templates

What is the new behavior?

Default to show preview first:
image

Toggling to show the html source code:
image

What is the current behavior?

No option to preview email templates - developers are forced to send out a test email to themselves to check that the email is being rendered correctly

@kangmingtay kangmingtay requested a review from a team as a code owner January 23, 2024 17:26
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 7:23am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Jan 24, 2024 7:23am
docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 7:23am
studio ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 7:23am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 7:23am
ui-storybook ⬜️ Ignored (Inspect) Jan 24, 2024 7:23am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 7:23am

Copy link

supabase bot commented Jan 23, 2024

Updates to Preview Branch (km/feat-email-template-previww) ↗︎

Deployments Status Updated
Database Wed, 24 Jan 2024 07:21:28 GMT
Services Wed, 24 Jan 2024 07:21:28 GMT
APIs Wed, 24 Jan 2024 07:21:28 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Wed, 24 Jan 2024 07:21:28 GMT
Seeding Wed, 24 Jan 2024 07:21:28 GMT

⚠️ Warning — Preview branch version (15.1.1.5) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database postgres://postgres:[PASSWORD]@db.kzvgyqmbiyzgwwdfnzze.supabase.co:5432/postgres
REST API https://kzvgyqmbiyzgwwdfnzze.supabase.co/rest/v1 ↗︎
GraphQL https://kzvgyqmbiyzgwwdfnzze.supabase.co/graphql/v1 ↗︎

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

@joshenlim
Copy link
Member

joshenlim commented Jan 24, 2024

image
lets use the <Tabs /> component here - stay consistent to a UI pattern

also can we keep the editor as the default view on render, then change the order of the tabs "Source" first, then "Preview" -> primary action here is to edit the template, secondary is previewing the template

@joshenlim joshenlim merged commit cdf1159 into master Jan 24, 2024
15 checks passed
@joshenlim joshenlim deleted the km/feat-email-template-previww branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants