Reset state and set enable form actions for add role sidebar. #20840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
@saltcod Please review :) |
|
@encima Is there any tag that I need to add for this PR to review? |
|
nope, you have done the hard work, we just need to review it! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
joshenlim
reviewed
Feb 7, 2024
apps/studio/components/interfaces/Database/Roles/CreateRolePanel.tsx
Outdated
Show resolved
Hide resolved
joshenlim
reviewed
Feb 7, 2024
apps/studio/components/interfaces/Database/Roles/CreateRolePanel.tsx
Outdated
Show resolved
Hide resolved
joshenlim
approved these changes
Feb 7, 2024
joshenlim
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Resolves #20839
What is the new behavior?
Using the form action buttons are not disabled & the value is being reset.
Additional context
hasChanges={true}is set totrueas to enable form action buttons, and if the user clicks on 'Save' with an empty value, form validation is triggered, hence I feel this is valid as the user will be blocked until they enter a valid value.create_role_sidebar_fix.webm