Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logs explorer look & feel very similar to sql editor #21055

Merged
merged 11 commits into from Feb 9, 2024

Conversation

jordienr
Copy link
Member

@jordienr jordienr commented Feb 6, 2024

What kind of change does this PR introduce?

  • update look & feel of log explorer to match SQL editor

What is the current behavior?

  • we have 2 different UXs for similar things

What is the new behavior?

they look very similar

Additional context

BEFORE

CleanShot 2024-02-06 at 17 23 53@2x

AFTER

CleanShot 2024-02-06 at 17 23 19@2x

@jordienr jordienr requested a review from a team as a code owner February 6, 2024 16:21
Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview Feb 9, 2024 11:23am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 11:23am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 11:23am
ui-storybook 🔄 Building (Inspect) Visit Preview Feb 9, 2024 11:23am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 11:23am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 11:23am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 11:23am

Copy link

supabase bot commented Feb 6, 2024

Updates to Preview Branch (fix/logs-explorer-ux) ↗︎

Deployments Status Updated
Database Fri, 09 Feb 2024 11:19:19 GMT
Services Fri, 09 Feb 2024 11:19:19 GMT
APIs Fri, 09 Feb 2024 11:19:19 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Fri, 09 Feb 2024 11:19:19 GMT
Seeding Fri, 09 Feb 2024 11:19:19 GMT

⚠️ Warning — Preview branch version (15.1.1.13) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database https://supabase.com/dashboard/project/yllyhdabwlnhgbxrnckz/settings/database ↗︎
REST https://yllyhdabwlnhgbxrnckz.supabase.co/rest/v1
GraphQL https://yllyhdabwlnhgbxrnckz.supabase.co/graphql/v1

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

@joshenlim
Copy link
Member

Some comments to make it slightly more similar to the SQL editor

  • "Results will be shown below"
    • Could we make this a dropdown like the SQL editor with just "Results", and we shift Download + Copy as markdown CTAs there
    • Save query + Run -> could we shift these 2 buttons down to the row where "Results" is? Field reference can stay up top
    • There seems to be an empty data grid when there's no results yet, can remove
      image

@jordienr jordienr enabled auto-merge (squash) February 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Related to supabase dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants