Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting a query thats not saved throwing an error #21082

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

joshenlim
Copy link
Member

No description provided.

@joshenlim joshenlim requested a review from a team as a code owner February 7, 2024 11:32
Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview Feb 7, 2024 11:38am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 11:38am
ui-storybook 🔄 Building (Inspect) Visit Preview Feb 7, 2024 11:38am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 11:38am
studio ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 11:38am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 11:38am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 11:38am

Copy link

supabase bot commented Feb 7, 2024

Updates to Preview Branch (fix/sql-editor-delete-query-not-saved) ↗︎

Deployments Status Updated
Database 🔄 Wed, 07 Feb 2024 11:32:36 GMT
Services 🔄 Wed, 07 Feb 2024 11:32:36 GMT
APIs 🔄 Wed, 07 Feb 2024 11:32:36 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations 🔄 Wed, 07 Feb 2024 11:32:36 GMT
Seeding 🔄 Wed, 07 Feb 2024 11:32:36 GMT

Connecting to this Preview Branch
URL
Database https://supabase.com/dashboard/project/pdywxtiforzmbypavvdg/settings/database ↗︎
REST https://pdywxtiforzmbypavvdg.supabase.co/rest/v1
GraphQL https://pdywxtiforzmbypavvdg.supabase.co/graphql/v1

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

@@ -607,7 +607,7 @@ const SQLEditor = () => {
<AiIconAnimation loading={isAiLoading} />
</motion.div>

<AnimatePresence initial={false} exitBeforeEnter>
<AnimatePresence initial={false} mode="wait">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like exitBeforeEnter is deprecated with the new version of framer-motion
i ran into a client error to replace it with mode wait locally

Copy link
Member

@jordienr jordienr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works!

@joshenlim joshenlim enabled auto-merge (squash) February 7, 2024 11:35
@joshenlim joshenlim merged commit 8841a46 into master Feb 7, 2024
14 of 15 checks passed
@joshenlim joshenlim deleted the fix/sql-editor-delete-query-not-saved branch February 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants