Fix table editor unable to update PK after renaming table #21285
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
Updates to Preview Branch (chore/fix-table-editor-unable-to-update-PK-after-renaming-table) ↗︎
Tasks are run on every commit but only new migration files are pushed.
Connecting to this Preview Branch
Branching Preview Branches by Supabase. |
| }: { | ||
| projectRef: string | ||
| connectionString: string | undefined | ||
| payload: CreateColumnPayload | ||
| selectedTable: PostgresTable | ||
| primaryKey?: Constraint |
There was a problem hiding this comment.
Why pass in the primary key when it's available on selectedTable.primary_keys?
There was a problem hiding this comment.
selectedTable.primary_keys from Postgrest is not in the format we need unfortunately
its missing the PK constraint name
and also doesnt deal with composite keys very well
hence why we've got a separate parameter to handle that
| { | ||
| enabled: typeof schema !== 'undefined' && typeof table !== 'undefined', | ||
| select(data) { | ||
| return ((data as any)?.result ?? []).map((constraint: Constraint) => constraint) |
There was a problem hiding this comment.
Does this do the same thing? The map isn't doing anything apart from adding types
| return ((data as any)?.result ?? []).map((constraint: Constraint) => constraint) | |
| return ((data as any)?.result ?? []) as Constraint[] |
There was a problem hiding this comment.
not sure why but TS is complaining 😕
There was a problem hiding this comment.
hmm maybe the whole map can just be removed entirely then?
There was a problem hiding this comment.
unless we rewrite it like this?
export const useTableConstraintsQuery = (
{ projectRef, connectionString, schema, table }: TableConstraintsVariables,
options: UseQueryOptions<ExecuteSqlData, TableConstraintsError, Constraint[]> = {}
) => {
return useExecuteSqlQuery(
{
projectRef,
connectionString,
sql: getTableConstraints({ schema, table }),
queryKey: ['table-constraints'],
},
{
enabled: typeof schema !== 'undefined' && typeof table !== 'undefined',
select(data) {
return ((data as any)?.result ?? []) as Constraint[]
},
...options,
}
)
}
There was a problem hiding this comment.
hmm maybe the whole map can just be removed entirely then?
oh 🤦 that worked hahaha sorry not sure why i was overcomplicating things haha
joshenlim
deleted the
chore/fix-table-editor-unable-to-update-PK-after-renaming-table
branch
Resolves #19341