Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y updates on table editor entity items #21482

Merged
merged 1 commit into from
Feb 23, 2024
Merged

a11y updates on table editor entity items #21482

merged 1 commit into from
Feb 23, 2024

Conversation

MildTomato
Copy link
Contributor

@MildTomato MildTomato commented Feb 23, 2024

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

  • a11y update to element
    • using role="button"
    • can now tab through items
    • hover bg styling added for focus and hover
    • fixed light mode bg issue
  • state active styling for menu dropdown in entity item
  • removed a nested button in tooltip
  • removed the tooltips for long titles, and instead gone for title which is supposedly how you really deal with this.

Please link any relevant issues here.

What is the new behavior?

Screenshot 2024-02-23 at 6 17 36 PM

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@MildTomato MildTomato requested a review from a team as a code owner February 23, 2024 10:18
@MildTomato MildTomato marked this pull request as draft February 23, 2024 10:18
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview Feb 23, 2024 10:23am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 10:23am
ui-storybook 🔄 Building (Inspect) Visit Preview Feb 23, 2024 10:23am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 10:23am
studio ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 10:23am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 10:23am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 10:23am

Copy link

supabase bot commented Feb 23, 2024

Updates to Preview Branch (fix/bg-selection) ↗︎

Deployments Status Updated
Database Fri, 23 Feb 2024 10:21:48 GMT
Services Fri, 23 Feb 2024 10:21:48 GMT
APIs Fri, 23 Feb 2024 10:21:48 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Fri, 23 Feb 2024 10:21:48 GMT
Seeding Fri, 23 Feb 2024 10:21:48 GMT

⚠️ Warning — Preview branch version (15.1.1.19) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database https://supabase.com/dashboard/project/hzhggfhgmghrolpuoaon/settings/database ↗︎
REST https://hzhggfhgmghrolpuoaon.supabase.co/rest/v1
GraphQL https://hzhggfhgmghrolpuoaon.supabase.co/graphql/v1

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

Copy link

@MildTomato
Copy link
Contributor Author

MildTomato commented Feb 23, 2024

  • removed the tooltips for long titles, and instead gone for title which is supposedly how you really deal with this.

shows native browser tooltip instead.
maybe controversial.

sorry, missed that out, added this into PR description.
important change

@saltcod

@ivasilov ivasilov merged commit 13ea35f into master Feb 23, 2024
19 of 22 checks passed
@ivasilov ivasilov deleted the fix/bg-selection branch February 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants