Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update table editor input and schema selector styling #21486

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

MildTomato
Copy link
Contributor

@MildTomato MildTomato commented Feb 23, 2024

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

  • Updated search input on Table Editor
Screenshot 2024-02-23 at 7 59 21 PM - top buttons on table editor are now aligned better (imo..) - a few dropdown triggers updated with data-open styling state - icons in a few buttons changed to 'foreground-muted' - removed the height hack on SchemaSelector - needs smoketesting - Buttons now have a focus state when dropdown/popover is open Screenshot 2024-02-23 at 8 12 01 PM

@MildTomato MildTomato requested a review from a team as a code owner February 23, 2024 12:01
Copy link

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview Feb 26, 2024 1:24pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 1:24pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 1:24pm
ui-storybook 🔄 Building (Inspect) Visit Preview Feb 26, 2024 1:24pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 1:24pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:24pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:24pm

Copy link

supabase bot commented Feb 23, 2024

Updates to Preview Branch (chore/improve-search-input-table-editor) ↗︎

Deployments Status Updated
Database Mon, 26 Feb 2024 13:23:06 GMT
Services Mon, 26 Feb 2024 13:23:06 GMT
APIs Mon, 26 Feb 2024 13:23:06 GMT

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Migrations Mon, 26 Feb 2024 13:23:06 GMT
Seeding Mon, 26 Feb 2024 13:23:06 GMT

⚠️ Warning — Preview branch version (15.1.1.19) does not match production database version (15.1.0.33).


Connecting to this Preview Branch
URL
Database https://supabase.com/dashboard/project/vtjrwflcpbpuunyjtmlk/settings/database ↗︎
REST https://vtjrwflcpbpuunyjtmlk.supabase.co/rest/v1
GraphQL https://vtjrwflcpbpuunyjtmlk.supabase.co/graphql/v1

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎

@MildTomato
Copy link
Contributor Author

MildTomato commented Feb 24, 2024

trying to fix tests

nvm, tests don't need fixing

@MildTomato
Copy link
Contributor Author

@saltcod Going to need another review as I failed to mention the elements now use title, so the Tooltip has been removed in favour of using native title hover behaviour for anchorlinks

@MildTomato MildTomato requested review from saltcod and a team February 26, 2024 05:24
@MildTomato
Copy link
Contributor Author

@saltcod approved offline, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants