Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage delete bucket modal fix styling #22109

Merged
merged 2 commits into from Mar 21, 2024

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented Mar 19, 2024

Resolves #22078

  • Fixes BucketRow overflowing when bucket name is long
  • Fixes DeleteBucketModal overflowing when bucket name is long
image

@joshenlim joshenlim requested a review from a team as a code owner March 19, 2024 10:10
Copy link

supabase bot commented Mar 19, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:11am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:11am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:11am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Mar 20, 2024 3:11am
studio ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 3:11am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 3:11am
ui-storybook ⬜️ Ignored (Inspect) Mar 20, 2024 3:11am

@MildTomato
Copy link
Contributor

Could we fix the pattern component instead?

Maybe we just add truncate to the button ?

@joshenlim
Copy link
Member Author

joshenlim commented Mar 20, 2024

Maybe we just add truncate to the button ?

yeap can do - i'll add a truncate, but i'll still remove the bucket name from the button i think. Realised we don't do that across the dashboard (only storage), so just to keep things consistent

[update] odd the button components in TextConfirmModal already has a truncate on it actually. The grid class name on the DialogContent is the one that seems to be causing this overflowing issue

@joshenlim
Copy link
Member Author

pushed a fix up for TextConfirmModal, just changing the class names there based on the previous comment rather than updating the primitives

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshenlim joshenlim merged commit e05fed4 into master Mar 21, 2024
16 checks passed
@joshenlim joshenlim deleted the chore/fix-storage-delete-bucket-styling branch March 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form content is out of the form
3 participants