Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate guides to app router #23101

Merged
merged 66 commits into from
Jul 3, 2024
Merged

refactor: migrate guides to app router #23101

merged 66 commits into from
Jul 3, 2024

Conversation

charislam
Copy link
Contributor

@charislam charislam commented Apr 21, 2024

Migrate guides to App Router.

  • Checked I haven't broken metadata and Open Graph
  • Checked bundle size increase is reasonable
  • Checked mobile sizing and light/dark mode
  • Checked lazy loading of components still works
  • Checked command menu (search, docs AI)
  • Checked for no new console errors
  • Checked navigation between guides and reference pages
  • Check that redirects still work
  • Check that 404s don't look too stupid
image

Copy link

supabase bot commented Apr 21, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 2:19pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Jul 3, 2024 2:19pm
design-system ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 2:19pm
studio ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 2:19pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 2:19pm
studio-staging ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 2:19pm
ui-storybook ⬜️ Ignored (Inspect) Jul 3, 2024 2:19pm
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 2:19pm

@@ -36,45 +36,41 @@ export async function constructHeaders(
return headers
}

/**
* [Charis] A bunch of ts-ignore here because there's soemthing on with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"soemthing" is a misspelling of "something"

@MildTomato
Copy link
Contributor

MildTomato commented Apr 22, 2024

Just had a brief look through changes.

  • What about using one Layout (which is a "use client") which uses next/navigation to determine which menu id to use. Then you don't need a layout file for each guide section.

  • Could also use one page.tsx file using a catch all.

@charislam
Copy link
Contributor Author

Just had a brief look through changes.

  • What about using one Layout (which is a "use client") which uses next/navigation to determine which menu id to use. Then you don't need a layout file for each guide section.
  • Could also use one page.tsx file using a catch all.

good point, I had a pathological desire to push client components as far down as possible, but I don't think there's even anything particularly heavy to render in there 🤔 I'll move the layout and pages up

@charislam charislam changed the title dev,feat: migrate docs to app router pt 1 migrate docs to app router pt 1 Apr 23, 2024
@charislam charislam marked this pull request as ready for review June 28, 2024 21:41
@charislam charislam changed the title migrate docs to app router pt 1 refactor: migrate guides to app router Jun 28, 2024
apps/docs/app/[...slug]/_page.tsx Outdated Show resolved Hide resolved
@charislam charislam merged commit f4779d4 into master Jul 3, 2024
18 checks passed
@charislam charislam deleted the refactor/app-router branch July 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants