Chore/gracefully handle large text or json in table editor #26792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
No changes detected in Branching Preview Branches by Supabase. |
alaister
reviewed
May 27, 2024
saltcod
reviewed
May 28, 2024
…tor' of github.com:supabase/supabase into chore/gracefully-handle-large-text-or-json-in-table-editor
saltcod
reviewed
May 28, 2024
saltcod
approved these changes
May 28, 2024
joshenlim
deleted the
chore/gracefully-handle-large-text-or-json-in-table-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently setting the limit for max characters we allow to render in the dashboard to be at 10Kb, although happy to debate what that number should be (I think it can be higher)
Within the grid, if the cell value is beyond the threshold:
Clicking load will then attempt to load the whole value:
Likewise within the side panel:
If the value is too large, the input field itself is disabled - CTA to edit via expanding the editor
Side note: updated the actions here to be behind a dropdown so it takes up less real estate
Same UX:
