Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: studio bugs #6872

Merged
merged 8 commits into from
May 18, 2022
Merged

fix: studio bugs #6872

merged 8 commits into from
May 18, 2022

Conversation

phamhieu
Copy link
Member

@phamhieu phamhieu commented May 18, 2022

What kind of change does this PR introduce?

  • refactor: extend dayjs once on _app instead of everywhere
  • fix: safari date parsing using dayjs CustomParseFormat
  • fix: handle undefined dateString
  • fix: safari by replacing gap- by space-x- on landing page
  • fix: replace spinner.gif with IconLoader
  • chore: tidy up

@phamhieu phamhieu requested a review from a team as a code owner May 18, 2022 04:09
@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated
about ⬜️ Ignored (Inspect) May 18, 2022 at 4:52AM (UTC)
zone-www-dot-com ⬜️ Ignored (Inspect) May 18, 2022 at 4:52AM (UTC)
zones-docs ⬜️ Ignored (Inspect) May 18, 2022 at 4:52AM (UTC)

@phamhieu phamhieu changed the title [WIP] fix: studio bugs fix: studio bugs May 18, 2022
@phamhieu phamhieu merged commit 52ecddc into master May 18, 2022
@phamhieu phamhieu deleted the hi/fix-studio-bugs branch May 18, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants