Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security patch fixes #40

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Security patch fixes #40

merged 5 commits into from
Feb 10, 2023

Conversation

steve-chavez
Copy link
Member

@steve-chavez steve-chavez commented Feb 2, 2023

Allows using configurable roles like:

reserved_roles = "anon*, authenticator*"

<role*> here means that the role can have GUCs and placeholders configured by the supautils.privileged_role, so it can do:

Configurable roles cannot be dropped or renamed by the privileged_role though.

Also allows using wildcards on placeholders defined on privileged_role_allowed_configs = "pgrst.*", this solves:

  • alter role authenticator set pgrst.db_plan_enabled to true(ref) - 146155e

Otherwise we'd have to whitelist all possible placeholders.

src/supautils.c Outdated Show resolved Hide resolved
* add privileged_role_allowed_configs wildcards
* correct misspelling "comfirm" -> "confirm" in functions
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor changes - LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants