Add line highlighting #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey this looks awesome, could you retarget the PR to the development-v1.3.0 branch and include a CHANGELOG line perhaps? 👍 |
|
Alright I did as you asked. I also had time to think about the code and I added some improvements. My reference for this feature was GitHub's line highlighting. Every time the URL's hash gets updated, you will be scrolled to that line except if you click a line number. |
|
Sounds pretty good I'll take a look at it somewhere this weekend and merge it! |
|
Alright, I'll probably end up making some changes before then. |
erlliam
force-pushed
the
master
branch
2 times, most recently
from
316a219
to
2d9d99b
Compare
Users can now click on line numbers to highlight a line. Line highlighting works by storing the file number and line number in the hash of the current page's URL. Each time the hash changes, the line will be highlighted and the line will be scrolled into view except if the user sets the hash by clicking on a line number. Example: #1L6 File 1, line 6 will be highlighted
|
Perfect, thank you. A 1.3 release will be upcoming somewhere in the next weeks with this included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now click on the line numbers to highlight a line. They can share the link of the page and visitors will be scrolled to the line. The way this works is by storing the file number and line number in the hash of the URL.
Hash: #1L6
Will highlight the first file's 6th line.
pinnwand-line-hightlighting.mp4
Resolves #39