Add line range(s) highlight support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes user wants to highlight a range instead of just one line, this commit adds support for doing that. This commit also adds support for highlighting ranges for many files at once. GitHub itself also only support highlighting one range per file, so we won't bother implementing many ranges per file just yet unless there is a demand for it. (Also our line range extension algo is slightly different to that in GitHub, oh wells.) The states required for this functionality demands more complexity as such we have added more internal states for tracking it, and actively sync it with the ground truth (the newest window location hash) when it changes.
|
Very nice; tried it out and it works well. If you want can you add a line to the changelog for the 1.5.0 release? This is major enough to add it there. I can also add it myself. |
supakeen
approved these changes
Jul 14, 2023
|
Done 🙌 |
supakeen
approved these changes
Jul 14, 2023
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes user wants to highlight a range instead of just one line, this PR adds support for doing that.
This PR also adds support for highlighting ranges for many files at once.
GitHub itself also only support highlighting one range per file, so we won't bother implementing many ranges per file just yet unless there is a demand for it. (Also our line range extension algo is slightly different to that in GitHub, oh wells.)
The states required for this functionality demands more complexity as such we have added more internal states for tracking it, and actively sync it with the ground truth (the newest window location hash) when it changes.