Skip to content

Commit

Permalink
fix: don't immediately exit on errors (#5336)
Browse files Browse the repository at this point in the history
Don't immediately exit on errors because this will hide diagnostic
information, and linter output.

Fix #5335

ci: add docs updates to changelog
  • Loading branch information
ferrarimarco committed Feb 27, 2024
1 parent 608bd50 commit 4a05d78
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/release-please/release-please-config.json
Expand Up @@ -24,6 +24,10 @@
{
"section": "🧰 Maintenance",
"type": "ci"
},
{
"section": "🧰 Maintenance",
"type": "docs"
}
],
"packages": {
Expand Down
2 changes: 1 addition & 1 deletion lib/linter.sh
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

set -o errexit
set -o nounset
set -o pipefail

Expand Down Expand Up @@ -658,6 +657,7 @@ UpdateLoopsForImage() {
# shellcheck disable=SC2317
cleanup() {
local -ri EXIT_CODE=$?
debug "Captured exit code: ${EXIT_CODE}"

if [ -n "${GITHUB_WORKSPACE:-}" ]; then
debug "Removing temporary files and directories"
Expand Down
1 change: 0 additions & 1 deletion scripts/linterVersions.sh
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

set -o errexit
set -o nounset
set -o pipefail

Expand Down

0 comments on commit 4a05d78

Please sign in to comment.