Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't immediately exit on errors #5336

Merged
merged 1 commit into from Feb 27, 2024
Merged

Don't immediately exit on errors #5336

merged 1 commit into from Feb 27, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Feb 27, 2024 •
edited

Proposed changes

  • Don't immediately exit on errors because this will hide diagnostic information, and linter output.
  • Add documentation updates PRs to the changelog.

Fix #5335

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Feb 27, 2024
@ferrarimarco ferrarimarco self-assigned this Feb 27, 2024
@ferrarimarco ferrarimarco mentioned this pull request Feb 27, 2024
Closed
1 task
@ferrarimarco
fix: don't immediately exit on errors
14e6923 
Don't immediately exit on errors because this will hide diagnostic
information, and linter output.

Fix #5335

ci: add docs updates to changelog
@ferrarimarco ferrarimarco merged commit 4a05d78 into main Feb 27, 2024
79 checks passed
@ferrarimarco ferrarimarco deleted the fix-exit-code branch February 27, 2024 13:57
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaefferlein kaefferlein kaefferlein approved these changes

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees

@ferrarimarco ferrarimarco

Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Super-linter actions fails without error
2 participants
@ferrarimarco @kaefferlein