Uninstall Dockerfilelint

[ferrarimarco]

Fixes #2179

Proposed Changes

Uninstall Dockerfilelint.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Requisites

• R cannot find a required library #2199
• Add RUST_2021 test and fix RUST_2021 file list #2215

[ferrarimarco]

@admiralAwkbar can you kindly update package.json and package-lock.json? I don't have the proper tooling handy on my dev workstation. Thanks!

[zkoppert]

Do you think this should be labelled as a breaking change? I could understand going either way.

[ferrarimarco]

@zkoppert done

[admiralAwkbar]

@ferrarimarco ask and you shall receive :)

[ferrarimarco]

thanks!

[ferrarimarco]

The PR is ready for review then :)

[admiralAwkbar]

@ferrarimarco lol somehow removing that broke r....

[ferrarimarco]

I checked, and I think this PR is not the root cause of that. Actually, I think the current main is affected by this issue as well.

[ferrarimarco]

The root cause is likely that the icu-libs package (upon which the R package depends, doesn't include the libicui18n.so.67 file.

I'll create a separate issue.

[waja]

This change breaks existing setups where .github/linters/.dockerfilelintrc exists:

2021-12-21 05:34:08 [INFO]   ----------------------------------------------
2021-12-21 05:34:08 [INFO]   ----------------------------------------------
2021-12-21 05:34:08 [INFO]   Linting [DOCKERFILE_HADOLINT] files...
2021-12-21 05:34:08 [INFO]   ----------------------------------------------
2021-12-21 05:34:08 [INFO]   ----------------------------------------------
2021-12-21 05:34:08 [INFO]   ---------------------------
2021-12-21 05:34:08 [INFO]   File:[/github/workspace/.github/linters/.dockerfilelintrc]
2021-12-21 05:34:08 [ERROR]   Found errors in [hadolint] linter!
2021-12-21 05:34:08 [ERROR]   Error code: 1. Command output:
------
/github/workspace/.github/linters/.dockerfilelintrc:1:1 unexpected 'r' expecting '#', ADD, ARG, CMD, COPY, ENTRYPOINT, ENV, EXPOSE, FROM, HEALTHCHECK, LABEL, MAINTAINER, ONBUILD, RUN, SHELL, STOPSIGNAL, USER, VOLUME, WORKDIR, a pragma, end of input, or whitespaces 
------