-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplication using a single Dockerfile #2178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
641a446
to
1c7d08e
Compare
c29ab85
to
5b0a675
Compare
admiralAwkbar
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferrarimarco This is amazing
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
* Reduce duplication using a single Dockerfile * Remove slim Dockerfile * Update PROD and RELEASE workflows * Fix apk package installing * Force link creation * Don't check if the versions file exist * Fix BUILD_DATE * Fix BUILD_DATE * Fix BUILD_DATE * Fix BUILD_DATE
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
* Reduce duplication using a single Dockerfile * Remove slim Dockerfile * Update PROD and RELEASE workflows * Fix apk package installing * Force link creation * Don't check if the versions file exist * Fix BUILD_DATE * Fix BUILD_DATE * Fix BUILD_DATE * Fix BUILD_DATE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
related to helping the project operate more efficiently
docker
Pull requests that update Docker code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
WRITE_LINTER_VERSIONS_FILE
totrue
would suffice. This is necessary because we build the versions file twice (slim image, standard image) because we add more linters in the standard image, and need to rebuild the file to include those additional linters.PS: I know that there's a lot of duplication in GitHub Actions workflow definitions, but it's a job for another day.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
Requisites