De-duplicate workflows #2220
Merged
De-duplicate workflows #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
added
infrastructure
ferrarimarco
force-pushed
the
only-one-pipeline
branch
from
2ddb732
to
74bbba9
Compare
ferrarimarco
changed the title
|
@admiralAwkbar if you like the concept behind this PR, I can go ahead and de-duplicate the other workflows as well. |
|
@ferrarimarco I love this PR! |
ferrarimarco
force-pushed
the
only-one-pipeline
branch
from
86258b0
to
a3f7a5d
Compare
admiralAwkbar
requested review from
admiralAwkbar,
GaboFDC,
Hanse00,
lindluni,
nemchik and
zkoppert
as code owners
|
I'll have a look at this in the coming days :) |
|
@ferrarimarco Hey! thanks! I took a quick stab at reducing as well. THis is a fun PR |
|
@ferrarimarco I think its right but would love a code check :) |
|
ah! yep, let me check. Thanks for pushing this, I've been swamped |
|
LGTM. I can't add a review for my own PR, but you can @admiralAwkbar Thanks for pushing this over the last mile! |
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
* De-duplicate deploy-DEV workflows * Add $ * Fix build target * Fix standard target * Consolidate workflows in a single one * more clean * add changes * fix spaces * fix release Co-authored-by: Admiral Awkbar <admiralawkbar@github.com>
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
* De-duplicate deploy-DEV workflows * Add $ * Fix build target * Fix standard target * Consolidate workflows in a single one * more clean * add changes * fix spaces * fix release Co-authored-by: Admiral Awkbar <admiralawkbar@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #2205
TODO
(requires #2178)
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance