Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "seems to be the simplier path" - Fix dockerfilelint -c option usage #398

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

past-due
Copy link
Contributor

@past-due past-due commented Jul 8, 2020

@admiralAwkbar:

Unfortunately commit 1da8c13 does not work for similar reasons to those listed in @LukeMondy's comment: https://github.com/github/super-linter/issues/305#issuecomment-651571788 (I have tested with and without this commit.)

(The GetLinterRules function sets LANGUAGE_LINTER_RULES to a path including the filename again.)

I suppose we could also modify how GetLinterRules works, but reverting this commit seems like the easier solution - given all other linters seem to expect a path including the filename - and fixes the use of the dockerfilelintrc file.

Note: dockerfilelint silently proceeds with default settings if the path provided to the -c option doesn't match what it expects, so it's critical to test with (a) a dockerfile that triggers default warnings and (b) a custom dockerfilelintrc file that disables them

Fixes #355

Proposed Changes

  • This reverts commit 1da8c13, which seems the simplest change to fix the dockerfilelintrc functionality (without substantial other changes to functions like GetLinterRules for this singular exception).

Readiness Checklist

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@admiralAwkbar
Copy link
Collaborator

@past-due amazing work! sorry for not properly testing it.

thanks again!

@admiralAwkbar admiralAwkbar added automation related to helping the project operate more efficiently bug Something isn't working labels Jul 8, 2020
@admiralAwkbar admiralAwkbar self-assigned this Jul 8, 2020
@admiralAwkbar admiralAwkbar merged commit 50ea4d6 into super-linter:master Jul 8, 2020
@past-due past-due deleted the fix_dockerfilelintrc_2 branch July 9, 2020 04:53
@LukeMondy
Copy link

@past-due thanks for doing all this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to helping the project operate more efficiently bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dockerfilelinter
3 participants