Revert "seems to be the simplier path" - Fix dockerfilelint -c option usage #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@admiralAwkbar:
Unfortunately commit 1da8c13 does not work for similar reasons to those listed in @LukeMondy's comment: https://github.com/github/super-linter/issues/305#issuecomment-651571788 (I have tested with and without this commit.)
(The
GetLinterRules
function setsLANGUAGE_LINTER_RULES
to a path including the filename again.)I suppose we could also modify how
GetLinterRules
works, but reverting this commit seems like the easier solution - given all other linters seem to expect a path including the filename - and fixes the use of the dockerfilelintrc file.Fixes #355
Proposed Changes
GetLinterRules
for this singular exception).Readiness Checklist
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance