Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible: fix globbing issue and allow .yaml too #436

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Ansible: fix globbing issue and allow .yaml too #436

merged 1 commit into from
Jul 18, 2020

Conversation

kunzese
Copy link
Contributor

@kunzese kunzese commented Jul 18, 2020 •
edited

Relates to #272

Proposed Changes

  1. Allow .yml and .yaml files to be linted
  2. Globbing is not possible within quotes (http://tldp.org/LDP/abs/html/globbingref.html)

Bash performs filename expansion on unquoted command-line arguments.

Readiness Checklist

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@kunzese kunzese mentioned this pull request Jul 18, 2020
Closed
nemchik
nemchik approved these changes Jul 18, 2020
View reviewed changes
Copy link
Collaborator

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nemchik nemchik added the bug Something isn't working label Jul 18, 2020
zkoppert
zkoppert approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution @kunzese and the initial review @nemchik!

@zkoppert zkoppert merged commit 13eef68 into super-linter:master Jul 18, 2020
@kunzese kunzese deleted the patch-1 branch July 19, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@IAmHughes IAmHughes Awaiting requested review from IAmHughes

@jwiebalk jwiebalk Awaiting requested review from jwiebalk

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kunzese @nemchik @zkoppert