Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest major slim version #4565

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Use latest major slim version #4565

merged 1 commit into from
Aug 17, 2023

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Aug 16, 2023 •
edited

fixes #4564

Proposed Changes

  1. Use generic latest major slim version instead of hard coded specific version (major.minor.patch)

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@zkoppert zkoppert self-assigned this Aug 16, 2023
@zkoppert zkoppert added the automation related to helping the project operate more efficiently label Aug 16, 2023
Hanse00
Hanse00 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@Hanse00 Hanse00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term we might want to generalize this further. What happens next time we have a major version change?

But for now, this will do.

@Hanse00 Hanse00 added this pull request to the merge queue Aug 16, 2023
@zkoppert zkoppert removed this pull request from the merge queue due to the queue being cleared Aug 16, 2023
@zkoppert zkoppert added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 6e983e8 Aug 17, 2023
4 checks passed
@zkoppert zkoppert deleted the zkoppert-patch-1 branch August 17, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

@Hanse00 Hanse00 Hanse00 approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees

@zkoppert zkoppert

Labels
automation related to helping the project operate more efficiently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The slim metadata file doesn't reference the latest release
3 participants
@zkoppert @ferrarimarco @Hanse00