Dart fixes #466
Merged
Dart fixes #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On second thought, I do not like this approach because it's asking `pub` questions it has already answered for each file, coupled with the fact that `|| true` means pub can fail for whatever reason. Looking at the other linters, and looking at the recent bug report in #120 I think it's safe to assume that pub, or any package manager can be called as a first step and then proceed to super lint.
- modified invalid file names (changed to anaylsis_options.yaml)
Noticed `glibc-${GLIBC_VERSION}.apk` was getting purged after and laying around in `/`.
cvega
requested review from
admiralAwkbar,
Hanse00,
IAmHughes,
jwiebalk,
nemchik and
zkoppert
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with dart pointed out in #120
This change backs out the
pub get || trueinlinter.shfor the following reasons:pub getshould only run oncepub-getshould run before super-linter in it's own stagepub getso they're were not testing the functionality/use case.Proposed Changes
pub geton each lint even with|| trueis undesirable coupled with the fact it does not retain+xon copy when buildingDockerfile(some how everything else in dart-sdk does?, not a super-linter issue).analysis_options.yamlfileReadiness Checklist
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance