Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target key in CD workflow #4773

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix target key in CD workflow #4773

merged 1 commit into from
Oct 20, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Oct 18, 2023 •
edited

Fixes #4771

Proposed Changes

Fix the CD workflow by passing the correct target when building the non-slim image.

Merge this after #4772 and #4778 to check if this fixes things.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco mentioned this pull request Oct 18, 2023
Merged
3 tasks
@ferrarimarco ferrarimarco added bug Something isn't working infrastructure related to project structure and maintenance automation related to helping the project operate more efficiently github_actions Pull requests that update Github_actions code labels Oct 18, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review October 19, 2023 07:20
@ferrarimarco ferrarimarco added the O: backlog 🤖 Backlog, stale ignores this label label Oct 19, 2023
@zkoppert zkoppert added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit fecdc81 Oct 20, 2023
3 checks passed
@zkoppert zkoppert deleted the fix-prod-deployment-target branch October 20, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees
No one assigned
Labels
automation related to helping the project operate more efficiently bug Something isn't working github_actions Pull requests that update Github_actions code infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-ScriptAnalyzer not found
2 participants
@ferrarimarco @zkoppert