Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same image tags in CI and CD #4778

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Use the same image tags in CI and CD #4778

merged 9 commits into from
Oct 19, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Oct 19, 2023 •
edited

Fixes #4777
Fixes #4776

Proposed Changes

  1. Use the same image tags for both CI and CD workflows.
  2. Dynamically set the image ID in Makefile.
  3. Remove unneeded coverage report commands from Makefile.
  4. Document how to run the test suite against arbitrary super-linter images.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance automation related to helping the project operate more efficiently O: backlog 🤖 Backlog, stale ignores this label labels Oct 19, 2023
@ferrarimarco ferrarimarco mentioned this pull request Oct 19, 2023
Merged
3 tasks
@ferrarimarco
Copy link
Collaborator Author

@zkoppert: we might need to tune branch protection rules because of the rename of the slim job :)

zkoppert
zkoppert approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@zkoppert zkoppert added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit dfedd30 Oct 19, 2023
3 checks passed
@zkoppert zkoppert deleted the fix-cd branch October 19, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees
No one assigned
Labels
automation related to helping the project operate more efficiently infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to deploy to production Failed to deploy to production
2 participants
@ferrarimarco @zkoppert