Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install clj-kondo from its container image #5064

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

ferrarimarco
Copy link
Collaborator

Related to #4986

Proposed Changes

Instead of providing a script to install clj-kondo, grab it from its container image so that we can benefit from automated dependency updates.

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added O: backlog 🤖 Backlog, stale ignores this label dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Dec 24, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 24, 2023
Instead of providing a script to install clj-kondo, grab it from its
container image so that we can benefit from automated dependency
updates.
@ferrarimarco ferrarimarco merged commit 1dc74e1 into main Dec 25, 2023
7 checks passed
@ferrarimarco ferrarimarco deleted the clj-kondo-updates branch December 25, 2023 11:41
@harryzcy
Copy link
Contributor

harryzcy commented Feb 23, 2024

@ferrarimarco Hi, the script is introduced in #4347 to prepare for arm64 builds. The docker image doesn't provide a arm64 build. Can we revert back to installing via script?

I'm submitting a PR to clj-kondo at clj-kondo/clj-kondo#2289 instead

@ferrarimarco
Copy link
Collaborator Author

Thanks @harryzcy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants