Fix #2093: add arm64 docker image

[harryzcy]

Please answer the following questions and leave the below in as part of your PR.

• I have read the Clojure etiquette and will respect it when communicating on this platform.

• I have read the developer documentation.

• This PR corresponds to an issue with a clear problem statement.

• This PR contains a test to prevent against future regressions

• I have updated the CHANGELOG.md file with a description of the addressed issue.

---

Provide a arm64 docker image during release. Closes #2093.

[borkdude]

Thanks. I'll have a look at this hopefully next week

[borkdude]

@harryzcy Thanks for this PR.

With babashka we had similar scripts to build Docker images using buildx in bash. But because it was hard to maintain these scripts, @lispyclouds and @cap10morgan ported it to babashka:

https://github.com/babashka/babashka/blob/master/.circleci/script/docker.clj

I think that would be best here also so I don't have to maintain two very different setups. If you're willing to port this using the approach in the babashka repo, then I'm willing to accept the PR.

[borkdude]

@harryzcy It seems this PR is mostly in support of super-linter/super-linter#5070. Does that issue need multi-architecture docker images or is it sufficient to just download the linux aarch64 binary? If so you could just run the clj-kondo install script on a aarch64 docker image as well:

curl -sLO https://raw.githubusercontent.com/clj-kondo/clj-kondo/master/script/install-clj-kondo
chmod +x install-clj-kondo
./install-clj-kondo

[harryzcy]

I think that would be best here also so I don't have to maintain two very different setups. If you're willing to port this using the approach in the babashka repo, then I'm willing to accept the PR.

I'm not familiar with closure syntax. I'm not sure if I can.

It seems this PR is mostly in support of super-linter/super-linter#5070. Does that issue need multi-architecture docker images or is it sufficient to just download the linux aarch64 binary? If so you could just run the clj-kondo install script on a aarch64 docker image as well

I'm not the maintainer of super-linter. But I believe it's easier for them if there's a docker image available.
@ferrarimarco Can you take a look at this?

[borkdude]

I'm not familiar with closure syntax. I'm not sure if I can.

I'll take it from here then.

[harryzcy]

I'll take it from here then.

Thank you! @borkdude

[ferrarimarco]

It seems this PR is mostly in support of super-linter/super-linter#5070. Does that issue need multi-architecture docker images or is it sufficient to just download the linux aarch64 binary? If so you could just run the clj-kondo install script on a aarch64 docker image as well

I'm not the maintainer of super-linter. But I believe it's easier for them if there's a docker image available. @ferrarimarco Can you take a look at this?

Hi folks! We currently pull clj-kondo from its container image:

https://github.com/super-linter/super-linter/blob/a3046b34e64efe25bfd02dbc729f52f0a3296f80/Dockerfile#L26

This allows us to keep the clj-kondo up to date using DependaBot, but we don't necessarily need an arm64 container image.

(probably out of scope for this PR) I'm not familiar with the clj-kondo install script, but if we go that route, we likely need a way to install a fixed version of clj-kondo that we can keep up to date with DependaBot. We can get creative here, but let's not derail this thread too much :)

Thanks!

[borkdude]

The install script supports a --version flag

[borkdude]

I'll work on porting babashka's docker build to clj-kondo now. Hopefully done this week.

[borkdude]

Fixed on master. You can see the multi arch image here now:

https://hub.docker.com/layers/cljkondo/clj-kondo/2024.02.13-SNAPSHOT/images/sha256-ea849cf18ceec156ce35c17098aab0340beb5f5eaaa515392d8f56da3e3cd152?context=explore

Can you please test it out before I make a final release?

[harryzcy]

Fixed on master. You can see the multi arch image here now:

https://hub.docker.com/layers/cljkondo/clj-kondo/2024.02.13-SNAPSHOT/images/sha256-ea849cf18ceec156ce35c17098aab0340beb5f5eaaa515392d8f56da3e3cd152?context=explore

Can you please test it out before I make a final release?

@borkdude Thank you! Tested and it's working