Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-linter-locally.md to improve build locally #5788

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

nielm
Copy link
Contributor

@nielm nielm commented Jun 18, 2024

Proposed changes

Improve the instructions on the 'build locally' instructions to actually store the PAT in the local filesystem

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

ferrarimarco
ferrarimarco previously approved these changes Jun 18, 2024
@ferrarimarco ferrarimarco self-assigned this Jun 18, 2024
@ferrarimarco ferrarimarco added documentation Improvements or additions to documentation O: backlog 🤖 Backlog, stale ignores this label labels Jun 18, 2024
@ferrarimarco ferrarimarco added this to the 6.7.0 milestone Jun 18, 2024
@nielm nielm force-pushed the patch-1 branch 2 times, most recently from bc2d77d to b66d4c4 Compare June 18, 2024 14:45
Improve the instructions on the 'build locally' page to actually store the
github PAT in the local filesystem.
@ferrarimarco ferrarimarco added this pull request to the merge queue Jun 19, 2024
Merged via the queue into super-linter:main with commit 9d154f5 Jun 19, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants