Improving billing #912
Merged
Improving billing #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cancelling all other subscriptions when a new is added If only delete subscription from database if the current one's id equal to webhook one
|
Your Render PR Server URL is https://superagent-pr-912.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co0o8kg21fec739q3ei0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames
NEXT_PUBLIC_STRIPE_SECRET_KEYenvironment variable toSTRIPE_SECRET_KEYbecause this key should not be exposed to the browser.Fixes typo in api.py
Moves onboard logic to an API route.
Replacing stripe pricing table with a custom one. Now we're passing customer id to the checkout page. So the email address is read-only (this was causing issues in prod, because some users were not using the same email address that they used when they signed up to Superagent).
So, we can remove
NEXT_PUBLIC_STRIPE_DARK_PRICING_TABLE_IDandNEXT_PUBLIC_STRIPE_LIGHT_PRICING_TABLE_IDAdds ability to switch between payment plans.
Adds a check to verify stripe signature to prevent replay attacks
Depends on
#911
Test plan
NEXT_PUBLIC_STRIPE_SECRET_KEYwithSTRIPE_SECRET_KEYin libs/ui/.envhttps://www.loom.com/share/0cd00b713a2348028d8f89d29bc63763