Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better vocoder #273

Closed
wants to merge 5 commits into from
Closed

better vocoder #273

wants to merge 5 commits into from

Conversation

bramtayl
Copy link

@bramtayl bramtayl commented Feb 5, 2020

I based this on Audacity's implementation. Not sure what that implies for licensing

@joshpar
Copy link
Member

joshpar commented Feb 5, 2020

Thanks! Does this change the sound of the original class? If so, I'd prefer to have it us a different different *method name to retain the original. This isn't a judgement about whether it is better or not - but if it is different it represents a breaking change that users may not expect. You can see the *bark version as an example. As far as licensing, it is a concern if the algorithm or any of the parts of the recipe are owned by someone else. It may be a question for someone on the Audacity team OR it may fit in just fine with a GPL license.

@bramtayl
Copy link
Author

bramtayl commented Feb 5, 2020

Sure. What should I call the new method? In the audacity code the header says "Released under terms of the GNU General Public License version 2" so I'm guessing there shouldn't be too many problems?

@joshpar
Copy link
Member

joshpar commented Feb 5, 2020

You can call it *audacity if you want - I'd also include (in the file) a comment that describes where you got it, and links to any sources you referenced. IF there is an author mentioned for it on the Audacity page, I'd suggest reaching out to them to ask permission to use it or to at least let them know (as a courtesy). I've done this before as well.

@SteveDaulton
Copy link

The vocoder effect in Audacity is not a "traditional" vocoder. It's a quirky kind of "vocoder-like" effect. As such, I doubt that it would be a suitable replacement for SuperCollider's vocoder, though it could be considered as an additional effect.
As with the main Audacity application, the effect is licensed under the terms of GPL v2.

If you do use it, then it would be nice (though not compulsory) for you to credit Audacity® and "Edgar-RFT" (the original developer of this effect), possibly as a code comment.

@bramtayl
Copy link
Author

bramtayl commented Feb 5, 2020

Sure. I have no understanding of how these things work, but at least to my ears the vocoder from Audacity sounds a lot better from the vocoder from supercollider. The implementations seem fairly similar, so I suspect that whatever quirkiness applies to the Audacity implementation applies to the supercollider one as well.

@mossheim mossheim closed this Apr 17, 2021
@mossheim mossheim deleted the branch supercollider:master April 17, 2021 10:29
@jreus
Copy link

jreus commented Dec 3, 2021

Did this ever get ported over? I'd love to have more options for vocoder implementations in SC. The built-in Vocoder Ugen is very difficult to get a musical sound with.

Sure. I have no understanding of how these things work, but at least to my ears the vocoder from Audacity sounds a lot better from the vocoder from supercollider. The implementations seem fairly similar, so I suspect that whatever quirkiness applies to the Audacity implementation applies to the supercollider one as well.

@dyfer
Copy link
Member

dyfer commented Dec 3, 2021

I don't think this process was ever finished.
sc3-plugins are in a transitory state where we as a community are trying to decide how to best go about its future, with no clear path forward yet. While no "official" decision has been made, we might not be accepting new additions to the sc3-plugins while we are in this transitory state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants