New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better vocoder #273
better vocoder #273
Conversation
Thanks! Does this change the sound of the original class? If so, I'd prefer to have it us a different different *method name to retain the original. This isn't a judgement about whether it is better or not - but if it is different it represents a breaking change that users may not expect. You can see the *bark version as an example. As far as licensing, it is a concern if the algorithm or any of the parts of the recipe are owned by someone else. It may be a question for someone on the Audacity team OR it may fit in just fine with a GPL license. |
Sure. What should I call the new method? In the audacity code the header says "Released under terms of the GNU General Public License version 2" so I'm guessing there shouldn't be too many problems? |
You can call it *audacity if you want - I'd also include (in the file) a comment that describes where you got it, and links to any sources you referenced. IF there is an author mentioned for it on the Audacity page, I'd suggest reaching out to them to ask permission to use it or to at least let them know (as a courtesy). I've done this before as well. |
The vocoder effect in Audacity is not a "traditional" vocoder. It's a quirky kind of "vocoder-like" effect. As such, I doubt that it would be a suitable replacement for SuperCollider's vocoder, though it could be considered as an additional effect. If you do use it, then it would be nice (though not compulsory) for you to credit Audacity® and "Edgar-RFT" (the original developer of this effect), possibly as a code comment. |
Sure. I have no understanding of how these things work, but at least to my ears the vocoder from Audacity sounds a lot better from the vocoder from supercollider. The implementations seem fairly similar, so I suspect that whatever quirkiness applies to the Audacity implementation applies to the supercollider one as well. |
Did this ever get ported over? I'd love to have more options for vocoder implementations in SC. The built-in Vocoder Ugen is very difficult to get a musical sound with.
|
I don't think this process was ever finished. |
I based this on Audacity's implementation. Not sure what that implies for licensing