Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port vocoder to SuperCollider #420

Closed
bramtayl opened this issue Feb 5, 2020 · 4 comments
Closed

Port vocoder to SuperCollider #420

bramtayl opened this issue Feb 5, 2020 · 4 comments

Comments

@bramtayl
Copy link

bramtayl commented Feb 5, 2020

Hello! I was wanting a better vocoder in SuperCollider so I ported your implementation. See the PR. I wanted to ask your permission first. If anyone is inclined, you might look over the code I wrote in SuperCollider to check whether I ported the implementation correctly.

@SteveDaulton
Copy link
Member

The vocoder effect in Audacity is not a "traditional" vocoder. It's a quirky kind of "vocoder-like" effect. As such, I doubt that it would be a suitable replacement for SuperCollider's vocoder, though they may accept is as an addition.
As with the main Audacity application, the effect is licensed under the terms of GPL v2.

@bramtayl
Copy link
Author

Sorry are you waiting for a response from me? What's the question? See the discussion on the PR

@SteveDaulton
Copy link
Member

I think this "issue" is resolved at our end. As far as I'm aware, if your code is licensed as (verbatim) "GPL v2 or later", then that protects the full rights of our GPL v2 license, and allows it to be used in GPL v3 or later. The important phrase in GPLv2 with respect to this is in section 6 of the GPL v2 license:
"You may not impose any further restrictions on the recipients' exercise of the rights granted herein."

As joshpar wrote in the PR, I would suggest including (in the file) a comment that describes where you got it, links to any sources you referenced, and the name of the original author. I don't think that is legally required, but is generally considered to be courteous and good practice.

@bramtayl
Copy link
Author

Ok I did that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants