To be rebased: bw compat in doesNotUnderstand

SCClassLibrary/Common/Core/Object.sc

@@ -362,11 +362,32 @@ Object  {
 	subclassResponsibility { arg method;
 		SubclassResponsibilityError(this, method, this.class).throw;
 	}
-	doesNotUnderstand { arg selector ... args;
-		DoesNotUnderstandError(this, selector, args).throw;
+	doesNotUnderstand { |selector ...args|
+		// if the class has a custom 'doesNotUnderstandWithKeys' method, call it.
+		var thisDoesNotUnderstandWithKeys = this.class.findRespondingMethodFor(\doesNotUnderstandWithKeys);
+		var objDoesNotUnderstandWithKeys = Object.findMethod(\doesNotUnderstandWithKeys);
+
+		if (thisDoesNotUnderstandWithKeys == objDoesNotUnderstandWithKeys){
+			DoesNotUnderstandError(this, selector, args).throw
+		} {
+			^this.doesNotUnderstandWithKeys(selector, args, [])
+		}
 	}
 	doesNotUnderstandWithKeys {|selector, argumentsArray, keywordArgumentPairs|
-		DoesNotUnderstandError(this, selector, argumentsArray, keywordArgumentPairs).throw;
+		// if the class has a custom 'doesNotUnderstand' method, post a warning and call it.
+		var thisDoesNotUnderstand = this.class.findRespondingMethodFor(\doesNotUnderstand);
+		var objDoesNotUnderstand = Object.findMethod(\doesNotUnderstand);
+
+		if (thisDoesNotUnderstand == objDoesNotUnderstand){
+			DoesNotUnderstandError(this, selector, argumentsArray, keywordArgumentPairs).throw;
+		} {
+			"% does not implement doesNotUnderstandWithKeys, "
+			"calling doesNotUnderstand and throwing away keyword arguments %."
+			.format(this.class, keywordArgumentPairs)
+			.warn;
+
+			^this.doesNotUnderstand(selector, *argumentsArray)
+		}
 	}
 	shouldNotImplement { arg method;
 		ShouldNotImplementError(this, method, this.class).throw;

testsuite/classlibrary/TestDoesNotUnderstandWithKeys.sc

@@ -4,6 +4,19 @@ TestDoesNotUnderstandWithKeysWorking {
 	}
 }
 
+
+Test_DNUWK_OnlyNonKW {
+	doesNotUnderstand { |selector ...args| ^args }
+}
+
+Test_DNUWK_OnlyKW {
+	doesNotUnderstandWithKeys { |selector, argumentsArray, keywordArgumentPairs|
+		^argumentsArray
+	}
+}
+
+
+
 TestDoesNotUnderstandWithKeys : UnitTest {
 	test_object_throws {
 		this.assertException(
@@ -25,4 +38,12 @@ TestDoesNotUnderstandWithKeys : UnitTest {
 			"Keyword args should be passsed to doesNotUnderstandWithKeys as an Array of keypairs."
 		);
 	}
+
+	test_respects_existing_doesNotUnderstand {
+		this.assertEquals(Test_DNUWK_OnlyNonKW().asdf('hurray!', asdf: 1), ['hurray!']);
+	}
+	test_respects_only_doesNotUnderstandWithKeys {
+		this.assertEquals(Test_DNUWK_OnlyKW().asdf('hurray!'), ['hurray!']);
+	}
+
 }