SCLang: Too many args passed to certain 'inline' methods

When the compile/parser see a method with only a single call, or a call to `super.something`, it 'inlines' it.

For these methods, all the users arguments were being passed through, regardless of how many were declared in the function signature.

This commit checks this, and removes any excess args from the stack.

Closes #1087

lang/LangSource/PyrInterpreter3.cpp

@@ -2980,6 +2980,10 @@ HOT void Interpret(VMGlobals* g) {
                         for (m = 0, mmax = methraw->numargs - numArgsPushed; m < mmax; ++m)
                             slotCopy(++sp, ++qslot);
                         numArgsPushed = methraw->numargs;
+                    } else if (methraw->varargs == 0 && numArgsPushed > methraw->numargs) {
+                        const auto num_slots_to_chop = numArgsPushed - methraw->numargs;
+                        sp -= num_slots_to_chop;
+                        numArgsPushed = methraw->numargs;
                     }
                     selector = slotRawSymbol(&meth->selectors);
                     goto msg_lookup;
@@ -2992,6 +2996,10 @@ HOT void Interpret(VMGlobals* g) {
                         for (m = 0, mmax = methraw->numargs - numArgsPushed; m < mmax; ++m)
                             slotCopy(++sp, ++qslot);
                         numArgsPushed = methraw->numargs;
+                    } else if (methraw->varargs == 0 && numArgsPushed > methraw->numargs){
+                        const auto num_slots_to_chop = numArgsPushed - methraw->numargs;
+                        sp -= num_slots_to_chop;
+                        numArgsPushed = methraw->numargs;
                     }
                     selector = slotRawSymbol(&meth->selectors);
                     classobj = slotRawSymbol(&slotRawClass(&meth->ownerclass)->superclass)->u.classobj;
@@ -3006,6 +3014,11 @@ HOT void Interpret(VMGlobals* g) {
                             slotCopy(++sp, ++qslot);
                         numArgsPushed = methraw->numargs;
                     }
+                    else if (methraw->varargs == 0 && numArgsPushed > methraw->numargs) {
+                        const auto num_slots_to_chop = numArgsPushed - methraw->numargs;
+                        sp -= num_slots_to_chop;
+                        numArgsPushed = methraw->numargs;
+                    }
                     selector = slotRawSymbol(&meth->selectors);
                     index = methraw->specialIndex;
                     slotCopy(slot, &slotRawObject(slot)->slots[index]);
@@ -3023,6 +3036,11 @@ HOT void Interpret(VMGlobals* g) {
                             slotCopy(++sp, ++qslot);
                         numArgsPushed = methraw->numargs;
                     }
+                    else if (methraw->varargs == 0 && numArgsPushed > methraw->numargs) {
+                        const auto num_slots_to_chop = numArgsPushed - methraw->numargs;
+                        sp -= num_slots_to_chop;
+                        numArgsPushed = methraw->numargs;
+                    }
                     selector = slotRawSymbol(&meth->selectors);
                     slotCopy(slot, &g->classvars->slots[methraw->specialIndex]);
 

testsuite/classlibrary/TestCorrectArgCount.sc

@@ -0,0 +1,12 @@
+TestCorrectArgCountObj {
+	var <a, <b, <c;
+	*new {|a| ^super.newCopyArgs(a) }
+}
+TestCorrectArgCount : UnitTest {
+	test_correct_arg {
+		var o = TestCorrectArgCountObj(\a, \b, \c);
+		this.assertEquals(o.a, \a);
+		this.assertEquals(o.b, nil);
+		this.assertEquals(o.c, nil);
+	}
+}